Change in osmo-ttcn3-hacks[master]: pcu: Ignore dummy rlcmac packets in f_ms_rx_pkt_ass_pacch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jan 21 15:44:42 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22313 )

Change subject: pcu: Ignore dummy rlcmac packets in f_ms_rx_pkt_ass_pacch
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22313/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22313/1/pcu/GPRS_Components.ttcn@506 
PS1, Line 506: 			  sapi := PCU_IF_SAPI_PDTCH, fn := 0,
> Please fix spacing here, it's broken.
Ack


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22313/1/pcu/GPRS_Components.ttcn@512 
PS1, Line 512: as_ms_rx_pkt_ass_pacch
> I am sorry, but this altstep is pretty much useless for anything else than f_ms_rx_pkt_ass_pacch(). […]
I agree it's of now use *now*, but I'm already redoing it as a first step / test for follow-up patches where I start using the new BTS port which allows for matching different RLCMAC block types directly on receive().

So let's go for merging this patch now and get rid of sporadic failures, and I'll finish working on the other patches implementing the new BTS port when I find some time.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22313
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a10d3a7383d8534e9263864b4130a96392e6198
Gerrit-Change-Number: 22313
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Jan 2021 15:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/c30ec965/attachment.htm>


More information about the gerrit-log mailing list