This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22349 ) Change subject: gprs_ns2_vc_fsm: fix nullpointer dereference when sending uintdata ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22349/1/src/gb/gprs_ns2_vc_fsm.c File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/22349/1/src/gb/gprs_ns2_vc_fsm.c@759 PS1, Line 759: if (nsh->pdu_type == NS_PDUT_UNITDATA) { : /* UNITDATA have to free msg because it might send the msg layer upwards */ : osmo_fsm_inst_dispatch(fi, GPRS_NS2_EV_RX_UNITDATA, msg); : return 0; : } why are we moving this block before the call to gprs_ns2_validate() ? If the validation fails, why is that so? I think we need to fix the validation (or the message, if it really is wrong) rather than bypassing validation completely. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7d7c95604ba4af4ed4b6019f1d432970225f8d7a Gerrit-Change-Number: 22349 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 21 Jan 2021 09:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210121/b843fe84/attachment.htm>