Change in libosmocore[master]: gprs_bssgp_rim: Return with EOPNOTSUPP on unsupported containers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Jan 19 19:07:55 UTC 2021


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/22319 )


Change subject: gprs_bssgp_rim: Return with EOPNOTSUPP on unsupported containers
......................................................................

gprs_bssgp_rim: Return with EOPNOTSUPP on unsupported containers

The current version of libosmocore only supports NACC related RIM
application containers. If the parser detects a different application
container it returns with EINVAL. Unfortunately this means that the
caller can not distinguish if there is a lack of support or a real
parsing error.

Change-Id: Ib5ada3554c04259764352888cf95bc4460cb2a54
Related: SYS#5103
---
M src/gb/gprs_bssgp_rim.c
1 file changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/22319/1

diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 7094f5f..2096977 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -405,7 +405,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -475,7 +475,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}
@@ -528,7 +528,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -547,7 +547,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -594,7 +594,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -613,7 +613,7 @@
 		case BSSGP_RAN_INF_APP_ID_SON:
 		case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 			/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-			return -EINVAL;
+			return -EOPNOTSUPP;
 		default:
 			return -EINVAL;
 		}
@@ -810,7 +810,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add parsers for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}
@@ -849,7 +849,7 @@
 	case BSSGP_RAN_INF_APP_ID_SON:
 	case BSSGP_RAN_INF_APP_ID_UTRA_SI:
 		/* TODO: add encoders for Si3, MBMS, SON, UTRA-SI app containers */
-		return -EINVAL;
+		return -EOPNOTSUPP;
 	default:
 		return -EINVAL;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib5ada3554c04259764352888cf95bc4460cb2a54
Gerrit-Change-Number: 22319
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/73e90ea8/attachment.htm>


More information about the gerrit-log mailing list