Change in libosmocore[master]: gprs_ns2: rework logging of Rx and Tx NS PDU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Jan 19 18:59:54 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22294 )

Change subject: gprs_ns2: rework logging of Rx and Tx NS PDU
......................................................................


Patch Set 7:

(1 comment)

I find the macros introduced in this commit a bit strange. Why not use usual LOG macros we introduce with a fixed prefix and wahtever the user wants after it?

https://gerrit.osmocom.org/c/libosmocore/+/22294/7/src/gb/gprs_ns2_internal.h 
File src/gb/gprs_ns2_internal.h:

https://gerrit.osmocom.org/c/libosmocore/+/22294/7/src/gb/gprs_ns2_internal.h@89 
PS7, Line 89: #define LOG_NS_RX_MESSAGE(nsvc, pdu_type) LOG_NS_MESSAGE(true, nsvc, pdu_type)
why not passing "RX" "TX" directly instead of true/false?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22294
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34b8fde2955ecc010d1dcd9512e1bba9211e2c0d
Gerrit-Change-Number: 22294
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jan 2021 18:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/167c4e9a/attachment.htm>


More information about the gerrit-log mailing list