Change in osmo-ttcn3-hacks[master]: NS_Emulation: Respect data_weight==0 or signalling_weight==0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Tue Jan 19 14:04:19 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22305 )

Change subject: NS_Emulation: Respect data_weight==0 or signalling_weight==0
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22305/1/gbproxy/GBProxy_Tests.ttcn 
File gbproxy/GBProxy_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22305/1/gbproxy/GBProxy_Tests.ttcn@71 
PS1, Line 71: 							data_weight := 0,
Shouldn't you set data_weight 1 here (and below) as well and only change it in the next commit where you introduce the second NS-VC?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22305
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9798e639b4bc8658482945970775b012b5840779
Gerrit-Change-Number: 22305
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Tue, 19 Jan 2021 14:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/ec2eb2dc/attachment.htm>


More information about the gerrit-log mailing list