Change in osmo-ttcn3-hacks[master]: gbproxy: Use separate NS-VC for data / signalling on SGSN side

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 19 14:03:21 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22306 )

Change subject: gbproxy: Use separate NS-VC for data / signalling on SGSN side
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22306/1/gbproxy/GBProxy_Tests.ttcn 
File gbproxy/GBProxy_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22306/1/gbproxy/GBProxy_Tests.ttcn@88 
PS1, Line 88: 					nsvci := 201
> Should we change the naming here to have nsei 101, 201, ... and nsvci for 101 be 101, 102, ... […]
I don't really care too much.  My main concern when doing suhc kind of allocations is to not use the same number at several levels.  So NSEI 101 with NSVCI 101 is a bad idea, as you would pass the test even if the code would once use the NSEI where the NSVCI is supposed to be used, and vice-versa.

Still, some similarity maskes sense.  But one could e.g. use NSE 1001 with NSVCI 1101, 1102, ... - in any case, it's outside of this patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22306
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If0e404bdf2c30a5e18748695608611be83f61109
Gerrit-Change-Number: 22306
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Tue, 19 Jan 2021 14:03:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210119/567d83c3/attachment.htm>


More information about the gerrit-log mailing list