Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp.h@50 
PS5, Line 50: 	const uint8_t *rim_cont;
> I still don't see why you don't want to use a struct holding a union of container types here, so the […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h@45 
PS2, Line 45: struct bssgp_ran_information_pdu {
> You could add a flag to the decode function to avoid decoding it optionally for instance.
Done


https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h 
File include/osmocom/gprs/gprs_bssgp_rim.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/5/include/osmocom/gprs/gprs_bssgp_rim.h@121 
PS5, Line 121: struct bssgp_ran_inf_req_rim_cont {
> Why isn't there a generic container struct containing in a union this struct here and other containe […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jan 2021 20:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/0990eebf/attachment.htm>