Change in osmo-sgsn[master]: gbproxy: Use IMSI cache for PTP paging and implement DUMMY_PAGING_PS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jan 18 18:07:42 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22298 )

Change subject: gbproxy: Use IMSI cache for PTP paging and implement DUMMY_PAGING_PS
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/22298/1/src/gbproxy/gb_proxy.c 
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/22298/1/src/gbproxy/gb_proxy.c@436 
PS1, Line 436: BSSGP_CAUSE_INV_MAND_INF
> But what should we do if we don't find the IMSI for the paging response? I can check if the spec pro […]
I would simply drop the message in such situations.  I thinkthis message really only happens with (nowhere implemented) EC-GSM-IoT, where the paging cycle can be many minutes, and where the PCU can actually reject paging if the next paging cycle is too far in the future.  I'm not sure what a SGNS would even do if tha happens.

We try our best - if there was a paging before (there should always be), then we have the IMSI in the cache.  If thre was none, we can log a NOTICE or ERROR in the log (and/or increment a counter), but I would not inform either SGSN or PCU about it.


https://gerrit.osmocom.org/c/osmo-sgsn/+/22298/1/src/gbproxy/gb_proxy.c@438 
PS1, Line 438: OSMO_ASSERT(nse->sgsn_facing);
> This is the nse extracted from the cache entry. […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22298
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I7243e0d4470cb62fa6db36d26002ccd6542b5147
Gerrit-Change-Number: 22298
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Mon, 18 Jan 2021 18:07:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/9cf53e4e/attachment.htm>


More information about the gerrit-log mailing list