This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/22251 ) Change subject: gbproxy: Implement IMSI cache ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > > Patch Set 2: Code-Review-1 > > > > Looks good to me. Except I'm unsure if crc16 as hash is good enough. Maybe @laforge can give additional feedback. > > I don't really have the mathematical background to say if it is good enough or not. In the Linux kernel we typically used the Bob Jenkins hash (https://burtleburtle.net/bob/hash/) see include/linux/jhash.h > > We usually expect a lot of variance in the final part of the ISMI, and little at the state. If one ignores the MCC/MNC (first 5 digits), 9 of the 10 decimal digits can actually even be represented in an uint32_t. So one would probably even get quite good distribution by simply using the modulo-32 representation of the 10 final IMSI digits. I just want to add that the hashtable is only 10 bit large anyway so using crc16 or 32 will still just result in one of 1024 buckets being chosen. > I guess without simulation it will be hard to predict what's the best approach. > > I'd say it should for sure be good enough to merge. > > Unrelated comment: It would be great to add "show" commands for bobth the IMSI and the TLLI cache. Ok, will do as separate commit -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/22251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If0a8d6cc1d63f2fb2c395cc5d4373a915bc2cb87 Gerrit-Change-Number: 22251 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Mon, 18 Jan 2021 12:34:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210118/66224fb8/attachment.htm>