Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: f_bssgp_get_tlli(): TLLI is optional in RADIO-STATUS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 17 17:17:25 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22248 )

Change subject: BSSGP_Emulation: f_bssgp_get_tlli(): TLLI is optional in RADIO-STATUS
......................................................................

BSSGP_Emulation: f_bssgp_get_tlli(): TLLI is optional in RADIO-STATUS

We must not dereference the TLLI IE unconditionally

Related: OS#4951
Change-Id: I463b25f5395127d155727d785eb7795ac0165fac
---
M library/BSSGP_Emulation.ttcnpp
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved



diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp
index 5eef645..5c825d6 100644
--- a/library/BSSGP_Emulation.ttcnpp
+++ b/library/BSSGP_Emulation.ttcnpp
@@ -1397,7 +1397,8 @@
 		return bssgp.pDU_BSSGP_RA_CAPABILITY_UPDATE.tLLI.tLLI_Value;
 	} else if (ischosen(bssgp.pDU_BSSGP_RA_CAPABILITY_UPDATE_ACK)) {
 		return bssgp.pDU_BSSGP_RA_CAPABILITY_UPDATE_ACK.tLLI.tLLI_Value;
-	} else if (ischosen(bssgp.pDU_BSSGP_RADIO_STATUS)) {
+	} else if (ischosen(bssgp.pDU_BSSGP_RADIO_STATUS) and
+		   ispresent(bssgp.pDU_BSSGP_RADIO_STATUS.tLLI)) {
 		return bssgp.pDU_BSSGP_RADIO_STATUS.tLLI.tLLI_Value;
 	} else if (ischosen(bssgp.pDU_BSSGP_SUSPEND)) {
 		return bssgp.pDU_BSSGP_SUSPEND.tLLI.tLLI_Value;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I463b25f5395127d155727d785eb7795ac0165fac
Gerrit-Change-Number: 22248
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210117/657e75c4/attachment.htm>


More information about the gerrit-log mailing list