Change in osmo-bts[master]: paging: refactor and optimize fill_paging_type_1()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 15 16:57:28 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22224 )

Change subject: paging: refactor and optimize fill_paging_type_1()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/22224/2/src/common/paging.c 
File src/common/paging.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22224/2/src/common/paging.c@383 
PS2, Line 383: 		append_p1_rest_octets(&bv, p1ro);
> Well you are not setting the same bytes twice: […]
But then you add more instructions for calculating the amount of bytes from bits... Also, you would probably need to deal with incomplete octets, where some bits are set and some are not. And this brings us back to bitvec_spare_padding() that we want to avoid.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I90473356b396e5dd9326598aca025afacca4afc8
Gerrit-Change-Number: 22224
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jan 2021 16:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/1c87bec8/attachment.htm>


More information about the gerrit-log mailing list