Change in osmo-bts[master]: paging: refactor and optimize fill_paging_type_1()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Jan 15 16:52:09 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22224 )

Change subject: paging: refactor and optimize fill_paging_type_1()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/22224/2/src/common/paging.c 
File src/common/paging.c:

https://gerrit.osmocom.org/c/osmo-bts/+/22224/2/src/common/paging.c@383 
PS2, Line 383: 		append_p1_rest_octets(&bv, p1ro);
> can you get num of bits/byte written from here and then memset only the bytes not filled here?
What do we win in this case? We could of course calculate that from bv.cur_bit, but I don't think it's such a significant improvement.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I90473356b396e5dd9326598aca025afacca4afc8
Gerrit-Change-Number: 22224
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 15 Jan 2021 16:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/788f8ce1/attachment.htm>


More information about the gerrit-log mailing list