Change in osmo-sip-connector[master]: mncc: mncc_create_remote_leg: use mncc_write instead of write direct ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jan 15 16:21:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/22204 )

Change subject: mncc: mncc_create_remote_leg: use mncc_write instead of write direct to the fd
......................................................................

mncc: mncc_create_remote_leg: use mncc_write instead of write direct to the fd

Change-Id: I870c16d7ee5e5424304f3c1c9fb78af418ae2577
---
M src/mncc.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/mncc.c b/src/mncc.c
index 83cfe3b..abfa01b 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -922,11 +922,10 @@
 	 *  - Screening, redirect?
 	 *  - Synth. the bearer caps based on codecs?
 	 */
-	rc = write(conn->fd.fd, &mncc, sizeof(mncc));
+	rc = mncc_write(conn, &mncc);
 	if (rc != sizeof(mncc)) {
 		LOGP(DMNCC, LOGL_ERROR, "Failed to send message leg(%u)\n",
 			leg->callref);
-		close_connection(conn);
 		talloc_free(leg);
 		return -1;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/22204
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I870c16d7ee5e5424304f3c1c9fb78af418ae2577
Gerrit-Change-Number: 22204
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/498e7ea2/attachment.htm>


More information about the gerrit-log mailing list