This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22206 ) Change subject: gprs_ns2_sns: clear local and remote entries when SNS failed ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22206/1/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/22206/1/src/gb/gprs_ns2_sns.c@261 PS1, Line 261: talloc_free(gss->ip4_local); > TALLOC_FREE(gss->ip4_local); […] Not sure I really prefer that since the name doesn't really indicate what's happening. otoh talloc_free ignores NULL so if you're worried about the size of the code here you could unconditionally talloc_free() and then set it to NULL -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie4db81acdd5f8ddf1a1f5dc7645d1144545d9c73 Gerrit-Change-Number: 22206 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 15 Jan 2021 14:39:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210115/a966e122/attachment.htm>