Change in osmo-pcu[master]: gprs_rlc_ts_alloc: ensure no rolling slots are allocated

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Jan 14 22:48:04 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22114 )

Change subject: gprs_rlc_ts_alloc: ensure no rolling slots are allocated
......................................................................


Patch Set 2:

(5 comments)

I've looked into the AllocTest.err, picked several cases and checked it is valid. I couldn't find any error.
We should remove AllocTest.err in the long run.

https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1//COMMIT_MSG@16 
PS1, Line 16: It gives an example for a multi slot class 5 UE which has 6 possible
> Seven, not six "other six" means 6 + 1, which matches exectancy given the max subset is 2 for mslot  […]
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1//COMMIT_MSG@21 
PS1, Line 21: 
> missing SYS# ticket
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1//COMMIT_MSG@23 
PS1, Line 23: 
> I would also add a referente to B.1 where it talks about the window size of the allocation set.
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1/src/gprs_rlcmac_ts_alloc.cpp 
File src/gprs_rlcmac_ts_alloc.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1/src/gprs_rlcmac_ts_alloc.cpp@574 
PS1, Line 574: 			 * E.g. 'UU-----U' is invalid for a 4 TN window. Excep 8 TN window. */
> "Except". Please add reference to the "window size" comment from TS 45  B. […]
Ack


https://gerrit.osmocom.org/c/osmo-pcu/+/22114/1/src/gprs_rlcmac_ts_alloc.cpp@600 
PS1, Line 600: 				if (mslot_class_get_type(mslot_class) == 1 && num_rx < 8 &&
> add the same comment as above (ul)
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I16019bdbe741b37b83b62749b840a3b7f4ddc6c7
Gerrit-Change-Number: 22114
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jan 2021 22:48:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/6163cca9/attachment.htm>


More information about the gerrit-log mailing list