Change in libosmocore[master]: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )

Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs
......................................................................


Patch Set 5:

(2 comments)

Thanks for reviewing!

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/2/include/osmocom/gprs/gprs_bssgp.h@45 
PS2, Line 45: struct bssgp_ran_information_pdu {
> struct bssgp_ran_information_pdu { […]
Thanks for your input. I see what you mean. I have changed it now for the RIM routing address IEs, but not for the container IE. Shall we parse that one too? However, the SGSN never looks into the container so at least there this would mean to decode the container and re-encode it, but we won't look at the contents there. What do you think?


https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h 
File include/osmocom/gprs/gprs_bssgp.h:

https://gerrit.osmocom.org/c/libosmocore/+/22046/1/include/osmocom/gprs/gprs_bssgp.h@45 
PS1, Line 45: struct bssgp_ran_information_pdu {
> shouldn't this be incorporated into struct osmo_bssgp_prim somehow?
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c
Gerrit-Change-Number: 22046
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Jan 2021 16:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210114/57dadec1/attachment.htm>