Change in osmo-bsc[master]: power_control: do not send BS Power IEs for channels on C0/TRX0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jan 13 23:06:29 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22165 )


Change subject: power_control: do not send BS Power IEs for channels on C0/TRX0
......................................................................

power_control: do not send BS Power IEs for channels on C0/TRX0

Reducing transmit power on C0/TRX0 is not permitted in GSM (there
are some energy saving enhancements though), so the BSC shall not
be sending any BS Power IEs when allocating channels there.

Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5
Related: SYS#4918
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/22165/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 2142219..e3270a7 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -597,14 +597,16 @@
 	}
 
 	if (bts->bs_power_ctrl.mode != GSM_PWR_CTRL_MODE_NONE)
-		msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);
+		if (trx != bts->c0) /* BS power control is not allowed on C0/TRX0 */
+			msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->bs_power);
 	if (bts->ms_power_ctrl.mode != GSM_PWR_CTRL_MODE_NONE)
 		msgb_tv_put(msg, RSL_IE_MS_POWER, lchan->ms_power);
 
 	msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);
 
 	/* BS/MS Power Control Parameters (if supported by BTS model) */
-	add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan);
+	if (trx != bts->c0) /* BS power control is not allowed on C0/TRX0 */
+		add_power_control_params(msg, RSL_IE_BS_POWER_PARAM, lchan);
 	add_power_control_params(msg, RSL_IE_MS_POWER_PARAM, lchan);
 
 	mr_config_for_bts(lchan, msg);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22165
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If8507992dfd90ade1edda99b72bf2420a702ccd5
Gerrit-Change-Number: 22165
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/b5443bec/attachment.htm>


More information about the gerrit-log mailing list