Change in osmo-bts[master]: power_control: print current RxLev and lower/upper thresholds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jan 13 14:22:33 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22117 )

Change subject: power_control: print current RxLev and lower/upper thresholds
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> So IIUC we don't print the desired target level anymore because that's no longer the aim of the algo? because we now target a given RxLev instead of a given received dBm? If that's not the case, then I think it still makes sense to print that value, which you are removing in this patch (and you are not saying in the commit message).

Well, since we introduced the hysteresis there is no "desired target level" anymore;  we have lower and upper thresholds instead.  Once the averaged RxLev enters the threshold window, the loop would not try to increase/decrease it (by decreasing/increasing attenuation) further towards the target, unless it leaves that window. So yes, I think it does not make sense to print the "target" anymore.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22117
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5f8c987054b2b01acdb9f525d06ca15bbc577070
Gerrit-Change-Number: 22117
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 13 Jan 2021 14:22:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/abab7628/attachment.htm>


More information about the gerrit-log mailing list