Change in osmo-bts[master]: power_control: BS power shall not be reduced on C0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jan 13 09:52:58 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22116 )

Change subject: power_control: BS power shall not be reduced on C0
......................................................................

power_control: BS power shall not be reduced on C0

It does not make sense to trigger the BS power control loop on C0,
as it's only allowed to reduce power on additional transceivers.

Change-Id: I4fdfe097ae6f9edde5f39ed4da8a559a14b3b38f
Related: SYS#4918
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 3f601fd..439db03 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1566,7 +1566,8 @@
 		lchan->meas.flags |= LC_UL_M_F_L1_VALID;
 
 		lchan_ms_pwr_ctrl(lchan, data[0] & 0x1f, data_ind->rssi);
-		lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) &data[5]);
+		if (trx->bts->c0 != trx) /* BS Power Control shall not be used on C0 */
+			lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) &data[5]);
 	} else
 		le = &lchan->lapdm_ch.lapdm_dcch;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22116
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4fdfe097ae6f9edde5f39ed4da8a559a14b3b38f
Gerrit-Change-Number: 22116
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/630d9e1e/attachment.htm>


More information about the gerrit-log mailing list