This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22123 ) Change subject: l1sap: use rxlev_full when no DTX was used ...................................................................... l1sap: use rxlev_full when no DTX was used At the moment only rxlev_sub is used to decide when the facch repetition should be activated, regardless if DTX is used. Lets check if DTX is actually used and use rxlev_full when DTX is not applied. Change-Id: I01ba57cf661f0e41b8df209c905f8d135013e472 Related: SYS#5114 --- M src/common/l1sap.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 2757d70..3f601fd 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -972,6 +972,7 @@ const struct gsm48_meas_res *meas_res; uint8_t upper; uint8_t lower; + uint8_t rxqual; if (!lchan->repeated_acch_capability.dl_facch_cmd && !lchan->repeated_acch_capability.dl_facch_all) @@ -1008,10 +1009,19 @@ lower = lchan->repeated_acch_capability.rxqual - 2; else lower = 0; - if (meas_res->rxqual_sub >= upper) + + /* When downlink DTX is applied, use RXQUAL-SUB, otherwise use + * RXQUAL-FULL. */ + if (meas_res->dtx_used) + rxqual = meas_res->rxqual_sub; + else + rxqual = meas_res->rxqual_full; + + if (rxqual >= upper) lchan->repeated_dl_facch_active = true; else if (meas_res->rxqual_sub <= lower) lchan->repeated_dl_facch_active = false; + } /* Special dequeueing function with SACCH repetition (3GPP TS 44.006, section 11) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I01ba57cf661f0e41b8df209c905f8d135013e472 Gerrit-Change-Number: 22123 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210113/2693abeb/attachment.htm>