Change in osmo-bsc[master]: stats: Add granularity to SDCCH/TCH/LU activity.

[iedemam]

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22103 )

Change subject: stats: Add granularity to SDCCH/TCH/LU activity.
......................................................................


Patch Set 6:

(1 comment)

Thanks! Updated patchset pushed to rename BTS_CTR_ASSIGNMENT_NO_CHANNEL_{SDCCH,TCH} to BTS_CTR_ASSIGNMENT_NO_CHANNEL_{SIGN,SPEECH}.

https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c 
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22103/1/src/osmo-bsc/assignment_fsm.c@543 
PS1, Line 543: case GSM48_CMODE_SIGN:
             : 			rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_SDCCH]);
             : 			break;
             : 		case GSM48_CMODE_SPEECH_V1:
             : 		case GSM48_CMODE_SPEECH_EFR:
             : 		case GSM48_CMODE_SPEECH_AMR:
             : 			rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_ASSIGNMENT_NO_CHANNEL_TCH]);
             : 			break;
> It is implementation dependent. […]
Agreed, that is more in line with the sense of this counter. I've changed them to BSC_CTR_ASSIGNMENT_{SIGN,SPEECH} to match the GSM48_CMODE_{SIGN,SPEECH} enum.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22103
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4df275e4770c5ff3643c79ba828e736986f8bb47
Gerrit-Change-Number: 22103
Gerrit-PatchSet: 6
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 11:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael at kapsulate.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210112/d31ffe4e/attachment.htm>