Change in osmo-ci[master]: jobs: don't overwrite PATH in "docker run"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 12 08:21:45 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/22096 )

Change subject: jobs: don't overwrite PATH in "docker run"
......................................................................

jobs: don't overwrite PATH in "docker run"

Don't mount $HOME/bin to /build_bin, and don't overwrite PATH to include
/build_bin anymore. This isn't needed because the scripts are installed
to /usr/local/bin inside the docker images now.

Depends: docker-playground I0820f13cd740f7d4a8999d279cef6ae293a67d81
Related: OS#4911
Change-Id: I45bd7ea56849dab839a98cfd52806f7cd288094e
---
M jobs/gerrit-verifications.yml
M jobs/master-builds.yml
M jobs/osmo-gsm-tester-runner.yml
3 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, approved; Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve



diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 32a81f3..d2e37cf 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -36,10 +36,9 @@
               -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
               -e OSMO_GSM_MANUALS_DIR="/build/deps/osmo-gsm-manuals" \
               -e PARALLEL_MAKE="$PARALLEL_MAKE" \
-              -e PATH="$PATH:/build_bin" \
               -e WITH_MANUALS="1" \
               -w /build -i -u build \
-              -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+              -v "$PWD:/build" \
               -v "$ARTIFACT_STORE:/artifact_store" \
     docker_img: '$USER/debian-stretch-jenkins'
     docker_img_erlang: '$USER/debian-buster-erlang'
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 93d2e75..3c3daf8 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -35,11 +35,10 @@
               -e OSMOPY_DEBUG_TCP_SOCKETS="1" \
               -e OSMO_GSM_MANUALS_DIR="/build/deps/osmo-gsm-manuals" \
               -e PARALLEL_MAKE="$PARALLEL_MAKE" \
-              -e PATH="$PATH:/build_bin" \
               -e PUBLISH="1" \
               -e WITH_MANUALS="1" \
               -w /build -i -u build \
-              -v "$PWD:/build" -v "$HOME/bin:/build_bin" \
+              -v "$PWD:/build" \
               -v "$ARTIFACT_STORE:/artifact_store" \
               -v "$HOME/.ssh:/home/build/.ssh:ro" \
     docker_img: '$USER/debian-stretch-jenkins'
diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml
index 087201f..25d8fd0 100644
--- a/jobs/osmo-gsm-tester-runner.yml
+++ b/jobs/osmo-gsm-tester-runner.yml
@@ -237,7 +237,6 @@
               -e BUILD_NUMBER="$BUILD_NUMBER" \
               -w /build -i \
               -v "$PWD:/build" \
-              -v "$HOME/bin:/build_bin" \
               -v "$HOME/.ssh:/home/build/.ssh:ro" \
               --cap-add=sys_nice \
               $USER/osmo-gsm-tester \

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/22096
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I45bd7ea56849dab839a98cfd52806f7cd288094e
Gerrit-Change-Number: 22096
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210112/2801e94b/attachment.htm>


More information about the gerrit-log mailing list