Change in osmo-bsc[master]: hodec2: to balance congestion, use overload percent

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jan 11 15:22:19 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22085 )

Change subject: hodec2: to balance congestion, use overload percent
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/22085/3/src/osmo-bsc/handover_decision_2.c 
File src/osmo-bsc/handover_decision_2.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22085/3/src/osmo-bsc/handover_decision_2.c@404 
PS3, Line 404: 	/* There can be no negative amount of free TCH/x, clamp to a minimum of zero available slots. This could
> I had unsigned values originally, but decided to change to signed purely for paranoia: […]
I would in that case use unsigned values in this function and add ASSERT to the wherever you think it can happen in the caller.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I55234c6c99eb02ceee52be0d7388bea14304930f
Gerrit-Change-Number: 22085
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Jan 2021 15:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/82d6e03f/attachment.htm>


More information about the gerrit-log mailing list