Change in osmo-bsc[master]: handover_test: safeguard against unhandled chan req

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Jan 11 14:35:36 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21981 )

Change subject: handover_test: safeguard against unhandled chan req
......................................................................

handover_test: safeguard against unhandled chan req

Change-Id: Ib0d5c4647af23e6729cc19e98b1870cdde2fe994
---
M tests/handover/handover_test.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c
index e3ccb64..3747bd8 100644
--- a/tests/handover/handover_test.c
+++ b/tests/handover/handover_test.c
@@ -704,8 +704,14 @@
 	switch (dh->c.msg_type) {
 	case RSL_MT_CHAN_ACTIV:
 		rc = parse_chan_act(lchan, dh->data);
-		if (rc == 0)
+		if (rc == 0) {
+			if (got_chan_req) {
+				fprintf(stderr, "Test script is erratic: a channel is requested"
+					" while a previous channel request is still unhandled\n");
+				exit(1);
+			}
 			got_chan_req = 1;
+		}
 		break;
 	case RSL_MT_RF_CHAN_REL:
 		rc = parse_chan_rel(lchan, dh->data);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib0d5c4647af23e6729cc19e98b1870cdde2fe994
Gerrit-Change-Number: 21981
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/4d678816/attachment.htm>


More information about the gerrit-log mailing list