Change in osmo-ttcn3-hacks[master]: Fix suspend/resume tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Mon Jan 11 02:33:03 UTC 2021


daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22048 )

Change subject: Fix suspend/resume tests
......................................................................

Fix suspend/resume tests

Ensure that a suspend/resume was sent before sending the *_(N)ACK. In
reality these can only happen together and our TLLI cache removes
the entries after it sees the corresponding (N)ACK so it will not
forward the second message.

Change-Id: Ie0fd81edb748d3c638e42c4418ca514095c55861
Related: SYS#4865, OS#4472
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  lynxis lazus: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index 59154e8..475b647 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -1024,6 +1024,12 @@
 
 		f_global_sgsn2pcu(pdu_tx, pdu_rx);
 
+		pdu_tx := ts_BSSGP_SUSPEND(tlli, ra_id);
+		/* we cannot use pdu_tx as there are some subtle differences in the length field :/ */
+		pdu_rx := tr_BSSGP_SUSPEND(tlli, ra_id);
+
+		f_global_pcu2sgsn(pdu_tx, pdu_rx);
+
 		/* These messages are simple passed through so just also test sending NACK */
 		pdu_tx := ts_BSSGP_SUSPEND_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);
 		/* we cannot use pdu_tx as there are some subtle differences in the length field :/ */
@@ -1060,6 +1066,12 @@
 
 		f_global_sgsn2pcu(pdu_tx, pdu_rx);
 
+		pdu_tx := ts_BSSGP_RESUME(tlli, ra_id, int2oct(i, 1));
+		/* we cannot use pdu_tx as there are some subtle differences in the length field :/ */
+		pdu_rx := tr_BSSGP_RESUME(tlli, ra_id, int2oct(i, 1));
+
+		f_global_pcu2sgsn(pdu_tx, pdu_rx);
+
 		/* These messages are simple passed through so just also test sending NACK */
 		pdu_tx := ts_BSSGP_RESUME_NACK(tlli, ra_id, BSSGP_CAUSE_UNKNOWN_MS);
 		/* we cannot use pdu_tx as there are some subtle differences in the length field :/ */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22048
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie0fd81edb748d3c638e42c4418ca514095c55861
Gerrit-Change-Number: 22048
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210111/4de8a5bf/attachment.htm>


More information about the gerrit-log mailing list