This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21848 ) Change subject: Introduce Neighbor resolution service ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h File include/osmocom/bsc/neighbor_ident.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@64 PS4, Line 64: #include <osmocom/ctrl/control_cmd.h> > Let's rather add a forward declaration for 'struct ctrl_handle' above, rather than including a heade […] Ack https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/include/osmocom/bsc/neighbor_ident.h@70 PS4, Line 70: _LAST_CTRL_NIDE_NEIGHBOR typo: NODE https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c File src/osmo-bsc/neighbor_ident.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident.c@337 PS4, Line 337: return CTRL_CMD_REPLY; > So if we reach this part, we leak the 'tmp'? Let's finally make use of OTC_SELECT! Ack https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/neighbor_ident_vty.c@164 PS4, Line 164: cell_id = (struct gsm0808_cell_id){ > This definition could be even shorter: […] Ack https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21848/4/src/osmo-bsc/osmo_bsc_main.c@966 PS4, Line 966: Failed to install neighbor control commands > Something seems to be wrong here. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib07c9d23026332a207d4b7a0f7b4e76c0094e379 Gerrit-Change-Number: 21848 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Fri, 08 Jan 2021 13:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210108/53e5a8a4/attachment.htm>