This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21980 ) Change subject: handover_test: include ack-chan in expect-chan ...................................................................... handover_test: include ack-chan in expect-chan Change-Id: Ic9f1e94b12334fed6bdce35beef94d8e2968f3ad --- M tests/handover/handover_test.c M tests/handover/test_penalty_timer.ho_vty 2 files changed, 0 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/21980/1 diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index 3c9b4ff..e3ccb64 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -971,11 +971,6 @@ gsm_lchan_name(lchan), gsm_lchan_name(chan_req_lchan)); exit(1); } -} - -static void _ack_chan_activ(struct gsm_lchan *lchan) -{ - fprintf(stderr, "- Acknowledging channel request on %s\n", gsm_lchan_name(lchan)); got_ho_req = 0; send_chan_act_ack(lchan, 1); } @@ -1005,15 +1000,6 @@ return CMD_SUCCESS; } -DEFUN(ack_chan, ack_chan_cmd, - "ack-chan", - "ACK a previous Channel Request\n") -{ - OSMO_ASSERT(got_chan_req); - _ack_chan_activ(chan_req_lchan); - return CMD_SUCCESS; -} - DEFUN(expect_ho_req, expect_ho_req_cmd, "expect-ho-req " LCHAN_ARGS, "Expect a handover of a given lchan\n" @@ -1067,7 +1053,6 @@ struct gsm_lchan *to = parse_lchan_args(argv+4); _expect_chan_activ(to); - _ack_chan_activ(to); _expect_ho_req(from); send_ho_detect(to); send_ho_complete(to, true); @@ -1152,7 +1137,6 @@ install_element(CONFIG_NODE, &congestion_check_cmd); install_element(CONFIG_NODE, &expect_no_chan_cmd); install_element(CONFIG_NODE, &expect_chan_cmd); - install_element(CONFIG_NODE, &ack_chan_cmd); install_element(CONFIG_NODE, &expect_ho_req_cmd); install_element(CONFIG_NODE, &ho_detection_cmd); install_element(CONFIG_NODE, &ho_complete_cmd); diff --git a/tests/handover/test_penalty_timer.ho_vty b/tests/handover/test_penalty_timer.ho_vty index be25c20..7b0d266 100644 --- a/tests/handover/test_penalty_timer.ho_vty +++ b/tests/handover/test_penalty_timer.ho_vty @@ -7,7 +7,6 @@ set-ts-use trx 0 0 states * TCH/F - - - - - - meas-rep lchan 0 0 1 0 rxlev 20 rxqual 0 ta 0 neighbors 30 expect-chan lchan 1 0 1 0 -ack-chan expect-ho-req lchan 0 0 1 0 ho-failed expect-ts-use trx 0 0 states * TCH/F - - - - - - -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic9f1e94b12334fed6bdce35beef94d8e2968f3ad Gerrit-Change-Number: 21980 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/dcf3db62/attachment.htm>