Change in osmo-bsc[master]: hodec2: cosmetic: add dBm unit to rxval logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jan 5 22:28:45 UTC 2021


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21970 )


Change subject: hodec2: cosmetic: add dBm unit to rxval logging
......................................................................

hodec2: cosmetic: add dBm unit to rxval logging

Change-Id: I58a5ae721b674576339360b1f03e91b015a1bf46
---
M src/osmo-bsc/handover_decision_2.c
1 file changed, 7 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/70/21970/1

diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c
index 9fab1fc..477f1eb 100644
--- a/src/osmo-bsc/handover_decision_2.c
+++ b/src/osmo-bsc/handover_decision_2.c
@@ -829,18 +829,18 @@
 
 	if (candidate->cil)
 		LOGPHOLCHANTOREMOTE(lchan, candidate->cil, LOGL_DEBUG,
-				    "RX level %d -> %d\n",
+				    "RX level %d dBm -> %d dBm\n",
 				    rxlev2dbm(rxlev), rxlev2dbm(candidate->avg));
 
 	if (candidate->bts == lchan->ts->trx->bts)
 		LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
-		     "RX level %d; "
+		     "RX level %d dBm; "
 		     HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",
 		     rxlev2dbm(candidate->avg),
 		     HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
 	else if (candidate->bts)
 		LOGPHOLCHANTOBTS(lchan, candidate->bts, LOGL_DEBUG,
-		     "RX level %d -> %d; "
+		     "RX level %d dBm -> %d dBm; "
 		     HO_CANDIDATE_FMT(f, F) "; " HO_CANDIDATE_FMT(h, H) "\n",
 		     rxlev2dbm(rxlev), rxlev2dbm(candidate->avg),
 		     HO_CANDIDATE_ARGS(f, F), HO_CANDIDATE_ARGS(h, H));
@@ -946,8 +946,8 @@
 		unsigned int pwr_hyst = ho_get_hodec2_pwr_hysteresis(bts->ho);
 		if (avg <= (av_rxlev + pwr_hyst)) {
 			LOGPHOCAND(&c, LOGL_DEBUG,
-				   "Not a candidate, because RX level (%d) is lower"
-				   " or equal than current RX level (%d) + hysteresis (%d)\n",
+				   "Not a candidate, because RX level (%d dBm) is lower"
+				   " or equal than current RX level (%d dBm) + hysteresis (%d)\n",
 				   rxlev2dbm(avg), rxlev2dbm(av_rxlev), pwr_hyst);
 			return;
 		}
@@ -958,8 +958,8 @@
 	min_rxlev = ho_get_hodec2_min_rxlev(neigh_cfg);
 	if (rxlev2dbm(avg) < min_rxlev) {
 		LOGPHOCAND(&c, LOGL_DEBUG,
-			   "Not a candidate, because RX level (%d) is lower"
-			   " than the minimum required RX level (%d)\n",
+			   "Not a candidate, because RX level (%d dBm) is lower"
+			   " than the minimum required RX level (%d dBm)\n",
 			   rxlev2dbm(avg), min_rxlev);
 		return;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21970
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I58a5ae721b674576339360b1f03e91b015a1bf46
Gerrit-Change-Number: 21970
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/09e15208/attachment.htm>


More information about the gerrit-log mailing list