Change in osmo-e1-hardware[master]: icE1usb fw: Expose error conditions from E1 driver

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Jan 5 22:25:57 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 )

Change subject: icE1usb fw: Expose error conditions from E1 driver
......................................................................


Patch Set 7:

(1 comment)

> Patch Set 7: Code-Review+1
> 
> (1 comment)
> 
> Minor typo ?
> But otherwise looks good.

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/7/firmware/ice40-riscv/icE1usb/ice1usb_proto.h 
File firmware/ice40-riscv/icE1usb/ice1usb_proto.h:

https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/7/firmware/ice40-riscv/icE1usb/ice1usb_proto.h@85 
PS7, Line 85: 	ICE1USB_IRQQ_T_ERRCNT		= 1,
> IRQQ ?
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Iba3e00a2b28a2fef6dbd986bfc706c1619c3a3ed
Gerrit-Change-Number: 21715
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 22:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/4ad2f788/attachment.htm>


More information about the gerrit-log mailing list