Change in osmo-pcu[master]: doc: Improve CS/MCS GPRS/EGPRS considerations in User Manual

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jan 5 13:06:54 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21943 )

Change subject: doc: Improve CS/MCS GPRS/EGPRS considerations in User Manual
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc 
File doc/manuals/chapters/configuration.adoc:

https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc@246 
PS1, Line 246: f
typo


https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc@250 
PS1, Line 250: encoding and decoding of 8-PSK modulation
This looks confusing, modulation is not something you encode and decode. I would say:

  "... the BTS must support 8-PSK modulation"


https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc@250 
PS1, Line 250: in the event 8-PSK
I may be wrong, but using "in the event" looks inappropriate in this context. It's not something that happens sporadically or unexpectedly, so it's not an event. Maybe "in case if 8-PSK is not supported"?


https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc@266 
PS1, Line 266: - It is possible to improve EGPRS performance (in particular, the TBF
Copyright! :D


https://gerrit.osmocom.org/c/osmo-pcu/+/21943/1/doc/manuals/chapters/configuration.adoc@302 
PS1, Line 302: encoded in GMSK
"modulated with GMSK" or "GMSK modulated"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21943
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7b205f5cab5862058a408f628925beb9f0f60a92
Gerrit-Change-Number: 21943
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jan 2021 13:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210105/1090e789/attachment.htm>


More information about the gerrit-log mailing list