This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21912 )
Change subject: vty: fix wrong attributes for UL/DL ACCH repetition commands
......................................................................
vty: fix wrong attributes for UL/DL ACCH repetition commands
None of those commands apply immediately, they only affect newly
established logical channels. The reason is that the related
IEs are only getting sent on channel activation / assignment.
Change-Id: I06c7851115fb31d1eb92c400d9724f4f051bd171
Related: SYS#5114
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 42 insertions(+), 39 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 34ea87e..14be3fa 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -2744,13 +2744,14 @@
#define REP_ACCH_STR "FACCH/SACCH repetition\n"
-DEFUN_ATTR(cfg_bts_rep_dl_facch,
- cfg_bts_rep_dl_facch_cmd,
- "repeat dl-facch (command|all)",
- REP_ACCH_STR
- "Enable DL-FACCH repetition for this BTS\n"
- "command LAPDm frames only\n"
- "all LAPDm frames\n", CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_bts_rep_dl_facch,
+ cfg_bts_rep_dl_facch_cmd,
+ X(BSC_VTY_ATTR_NEW_LCHAN),
+ "repeat dl-facch (command|all)",
+ REP_ACCH_STR
+ "Enable DL-FACCH repetition for this BTS\n"
+ "command LAPDm frames only\n"
+ "all LAPDm frames\n")
{
struct gsm_bts *bts = vty->index;
@@ -2770,11 +2771,12 @@
return CMD_SUCCESS;
}
-DEFUN_ATTR(cfg_bts_rep_no_dl_facch,
- cfg_bts_rep_no_dl_facch_cmd,
- "no repeat dl-facch",
- NO_STR REP_ACCH_STR
- "Disable DL-FACCH repetition for this BTS\n", CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_bts_rep_no_dl_facch,
+ cfg_bts_rep_no_dl_facch_cmd,
+ X(BSC_VTY_ATTR_NEW_LCHAN),
+ "no repeat dl-facch",
+ NO_STR REP_ACCH_STR
+ "Disable DL-FACCH repetition for this BTS\n")
{
struct gsm_bts *bts = vty->index;
@@ -2784,13 +2786,13 @@
return CMD_SUCCESS;
}
-DEFUN_ATTR(cfg_bts_rep_ul_dl_sacch,
- cfg_bts_rep_ul_dl_sacch_cmd,
- "repeat (ul-sacch|dl-sacch)",
- REP_ACCH_STR
- "Enable UL-SACCH repetition for this BTS\n"
- "Enable DL-SACCH repetition for this BTS\n",
- CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_bts_rep_ul_dl_sacch,
+ cfg_bts_rep_ul_dl_sacch_cmd,
+ X(BSC_VTY_ATTR_NEW_LCHAN),
+ "repeat (ul-sacch|dl-sacch)",
+ REP_ACCH_STR
+ "Enable UL-SACCH repetition for this BTS\n"
+ "Enable DL-SACCH repetition for this BTS\n")
{
struct gsm_bts *bts = vty->index;
@@ -2808,12 +2810,13 @@
return CMD_SUCCESS;
}
-DEFUN_ATTR(cfg_bts_rep_no_ul_dl_sacch,
- cfg_bts_rep_no_ul_dl_sacch_cmd,
- "no repeat (ul-sacch|dl-sacch)",
- NO_STR REP_ACCH_STR
- "Disable UL-SACCH repetition for this BTS\n"
- "Disable DL-SACCH repetition for this BTS\n", CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_bts_rep_no_ul_dl_sacch,
+ cfg_bts_rep_no_ul_dl_sacch_cmd,
+ X(BSC_VTY_ATTR_NEW_LCHAN),
+ "no repeat (ul-sacch|dl-sacch)",
+ NO_STR REP_ACCH_STR
+ "Disable UL-SACCH repetition for this BTS\n"
+ "Disable DL-SACCH repetition for this BTS\n")
{
struct gsm_bts *bts = vty->index;
@@ -2825,20 +2828,20 @@
return CMD_SUCCESS;
}
-DEFUN_ATTR(cfg_bts_rep_rxqual,
- cfg_bts_rep_rxqual_cmd,
- "repeat rxqual (0|1|2|3|4|5|6|7)",
- REP_ACCH_STR
- "Set UL-SACCH/DL-FACCH rxqual threshold-ber\n"
- "0 disabled (always on)\n"
- "1 0.26% to 0.30% BER\n"
- "2 0.51% to 0.64% BER\n"
- "3 1.0% to 1.3% BER\n"
- "4 1.9% to 2.7% BER (default)\n"
- "5 3.8% to 5.4% BER\n"
- "6 7.6% to 11.0% BER\n"
- "7 Greater than 15.0% BER\n",
- CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_bts_rep_rxqual,
+ cfg_bts_rep_rxqual_cmd,
+ X(BSC_VTY_ATTR_NEW_LCHAN),
+ "repeat rxqual (0|1|2|3|4|5|6|7)",
+ REP_ACCH_STR
+ "Set UL-SACCH/DL-FACCH rxqual threshold-ber\n"
+ "0 disabled (always on)\n"
+ "1 0.26% to 0.30% BER\n"
+ "2 0.51% to 0.64% BER\n"
+ "3 1.0% to 1.3% BER\n"
+ "4 1.9% to 2.7% BER (default)\n"
+ "5 3.8% to 5.4% BER\n"
+ "6 7.6% to 11.0% BER\n"
+ "7 Greater than 15.0% BER\n")
{
struct gsm_bts *bts = vty->index;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I06c7851115fb31d1eb92c400d9724f4f051bd171
Gerrit-Change-Number: 21912
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/164844e7/attachment.htm>