Change in osmo-bts[master]: power_control: generalize the arguments of do_pf_ewma()

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21907 )

Change subject: power_control: generalize the arguments of do_pf_ewma()
......................................................................


Patch Set 4:

(1 comment)

Thank you!

https://gerrit.osmocom.org/c/osmo-bts/+/21907/4/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21907/4/src/common/power_control.c@76 
PS4, Line 76: 	if (*Avg100 == 0) {
> Agree with the first run, but you seem to have overlooked my comment regarding this patch being hit  […]
Oh, damn, you're right. We currently feed it with dBm values where value 0 is very unlikely. However, for RxLev (0..63) and RxQual (0..7) it will likely become a problem. We can add a boolean flag to the state to avoid this.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21907
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I439c00b394da670e314f217b3246cc85ce8213c6
Gerrit-Change-Number: 21907
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Jan 2021 11:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/510fd44a/attachment.htm>