Change in osmo-iuh[master]: hnbgw: Use LOGHNB() to add log context information to log lines

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jan 4 10:10:04 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/21900 )

Change subject: hnbgw: Use LOGHNB() to add log context information to log lines
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-iuh/+/21900/1/src/context_map.c 
File src/context_map.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/21900/1/src/context_map.c@128 
PS1, Line 128: 	LOGP(DMAIN, LOGL_NOTICE, "Unable to resolve map for CN " "connection ID %p/%u\n", cn, scu_conn_id);
if you put it in the same line you don't need to split the string in 2.


https://gerrit.osmocom.org/c/osmo-iuh/+/21900/1/src/hnbgw.c 
File src/hnbgw.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/21900/1/src/hnbgw.c@277 
PS1, Line 277: struct hnb_context *hnb_context_alloc(struct hnb_gw *gw, struct osmo_stream_srv_link *link, int new_fd)
I see there's hnbg_context and hnb_gw, so it may make sense to call the macro LOGHNBCTX, up to you.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/21900
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Ia16eed4ca5e9ef231259e94c65105f7586f366bc
Gerrit-Change-Number: 21900
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Jan 2021 10:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/f349b807/attachment.htm>


More information about the gerrit-log mailing list