Change in osmo-sgsn[master]: gbproxy: Add config option to name an SGSN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Jan 4 10:00:32 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21882 )

Change subject: gbproxy: Add config option to name an SGSN
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/2/src/gbproxy/gb_proxy.c 
File src/gbproxy/gb_proxy.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/2/src/gbproxy/gb_proxy.c@224 
PS2, Line 224: 		LOGPS
> do we want this as NOTICE? Even the existing "INFO" might be high fro something that has the potenti […]
Does this logic of sending to first SGSN make sense anyway? Can it happen that we have no TLLI?
in any case,  this change seems not related to this patch.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/2/src/gbproxy/gb_proxy.c@230 
PS2, Line 230: 		i
> is this change related to SGSN naming?
Ack


https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/2/src/gbproxy/gb_proxy.c@233 
PS2, Line 233: 		sgsn = llist_first_entry(&cfg->sgsns, struct gbproxy_sgsn, list);
This all looks like a separate patch imho.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21882/2/src/gbproxy/gb_proxy.c@300 
PS2, Line 300: 		DEBUGP(DGPRS, "CELL(%05u) using SGSN %s at NSE(%05u)\n", cell->bvci, sgsn->name, sgsn->nse->nsei);
why not using LOGPSGSN here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21882
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2a3410dd9bebb242957e13a63ed70e447204203c
Gerrit-Change-Number: 21882
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Jan 2021 10:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210104/7c8585be/attachment.htm>


More information about the gerrit-log mailing list