This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21924 ) Change subject: BSC_Tests: fix early mtc.stop in TC_chan_rel_rr_cause() ...................................................................... BSC_Tests: fix early mtc.stop in TC_chan_rel_rr_cause() Calling f_shutdown_helper() in f_tc_chan_rel_rr_cause() leads to premature test case termination, so only one out of 6 cause values gets checked. Move it to TC_chan_rel_rr_cause(). Change-Id: Ic7df15b496fc0750e4f694b1ae79398216f498a7 --- M bsc/BSC_Tests.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 175b820..87a15ea 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1947,7 +1947,6 @@ } f_expect_chan_rel(0, dt.rsl_chan_nr, expect_rll_rel_req := false, expect_rr_cause := expect_rr_cause); - f_shutdown_helper(); } /* Test that Clear Command cause codes affect the RR Channel Release cause code */ @@ -1960,6 +1959,8 @@ f_tc_chan_rel_rr_cause(GSM0808_CAUSE_RADIO_INTERFACE_MESSAGE_FAILURE, GSM48_RR_CAUSE_PROT_ERROR_UNSPC); f_tc_chan_rel_rr_cause(GSM0808_CAUSE_RADIO_INTERFACE_FAILURE, GSM48_RR_CAUSE_ABNORMAL_UNSPEC); f_tc_chan_rel_rr_cause(GSM0808_CAUSE_EQUIPMENT_FAILURE, GSM48_RR_CAUSE_ABNORMAL_UNSPEC); + + f_shutdown_helper(); } /* Test behavior if RSL EST IND for non-active channel */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic7df15b496fc0750e4f694b1ae79398216f498a7 Gerrit-Change-Number: 21924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210103/2f2b7181/attachment.htm>