This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21928 ) Change subject: BSC_Tests: fix unreachable code after f_shutdown_helper() ...................................................................... BSC_Tests: fix unreachable code after f_shutdown_helper() This function does 'mtc.stop', so it must be always called last. Change-Id: If2c991d6ac23e43aafd32814ca17cf2093cb1522 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/21928/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index fe50e06..f72ab22 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3681,9 +3681,9 @@ vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; - f_shutdown_helper(); f_vty_amr_start_mode_restore(true); + f_shutdown_helper(); } testcase TC_assignment_codec_amr_h() runs on test_CT { @@ -3709,9 +3709,9 @@ vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; - f_shutdown_helper(); f_vty_amr_start_mode_restore(false); + f_shutdown_helper(); } /* 'amr start-mode auto' should not keep the (unused) 'smod' bits from previous configuration */ @@ -3743,11 +3743,11 @@ vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; - f_shutdown_helper(); /* Clear the startmode bits to not affect subsequent tests, in case the bits should indeed stick around. */ f_vty_amr_start_mode_set(true, "1"); f_vty_amr_start_mode_restore(true); + f_shutdown_helper(); } function f_TC_assignment_codec_amr(boolean fr, octetstring mrconf, bitstring s8_s0, bitstring exp_s8_s0, @@ -4257,9 +4257,9 @@ vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); vc_conn.done; - f_shutdown_helper(); f_vty_amr_start_mode_restore(false); + f_shutdown_helper(); } /* test the procedure of the MSC requesting a Classmark Update: -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If2c991d6ac23e43aafd32814ca17cf2093cb1522 Gerrit-Change-Number: 21928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210103/8a730171/attachment.htm>