Change in libosmocore[master]: gprs_bssgp: add support for SGSN oriented RESET

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri Feb 26 16:03:24 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22945 )

Change subject: gprs_bssgp: add support for SGSN oriented RESET
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22945/2/src/gb/gprs_bssgp.c 
File src/gb/gprs_bssgp.c:

https://gerrit.osmocom.org/c/libosmocore/+/22945/2/src/gb/gprs_bssgp.c@134 
PS2, Line 134:  */
> missing return info
Ack


https://gerrit.osmocom.org/c/libosmocore/+/22945/2/src/gb/gprs_bssgp.c@143 
PS2, Line 143: 	msgb_bvci(msg) = 0; /* Signalling */
> BVCI_SIGNALLING
in the next commit


https://gerrit.osmocom.org/c/libosmocore/+/22945/2/src/gb/gprs_bssgp.c@150 
PS2, Line 150: 		bssgp_create_cell_id(bssgp_cid, ra_id, cell_id);
> I really wonder why do we have this kind of APIs storing into a buffer instead of having a packet st […]
don't ask me. i've refactored it a little bit to show you, that's not my fault ;)



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22945
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
Gerrit-Change-Number: 22945
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Feb 2021 16:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/508f8d22/attachment.htm>


More information about the gerrit-log mailing list