Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Enable by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 26 15:31:16 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23113 )

Change subject: StatsD_Checker: Enable by default
......................................................................

StatsD_Checker: Enable by default

It was previously disabled by default in order to avoid test breakage
with older versions of osmocom projects not supporting them. Since we
just did a new release, all -latest contian now master which should work
fine.

Don't remove the moduleparam yet in order to avoid breakage with some
cfg files in docker-playground.git still setting it to true.

Related: OS#5042
Change-Id: I4e2049c109986906d3c985ca2282174b1abff581
---
M bsc/BSC_Tests.default
M library/StatsD_Checker.ttcn
M ns/NS_Tests.default
M pcu/PCU_Tests.default
4 files changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve



diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default
index c5d1559..50c5c0a 100644
--- a/bsc/BSC_Tests.default
+++ b/bsc/BSC_Tests.default
@@ -29,6 +29,5 @@
 
 [MODULE_PARAMETERS]
 Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBSC";
-StatsD_Checker.mp_enable_stats := true;
 
 [EXECUTE]
diff --git a/library/StatsD_Checker.ttcn b/library/StatsD_Checker.ttcn
index 540e479..1c8fd12 100644
--- a/library/StatsD_Checker.ttcn
+++ b/library/StatsD_Checker.ttcn
@@ -38,7 +38,7 @@
 
 modulepar {
 	/* Whether to test stats values */
-	boolean mp_enable_stats := false;
+	boolean mp_enable_stats := true;
 }
 
 type record StatsDExpect {
diff --git a/ns/NS_Tests.default b/ns/NS_Tests.default
index 951c1c2..1c61bec 100644
--- a/ns/NS_Tests.default
+++ b/ns/NS_Tests.default
@@ -8,7 +8,6 @@
 
 [MODULE_PARAMETERS]
 Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoNSdummy";
-StatsD_Checker.mp_enable_stats := true;
 
 [TESTPORT_PARAMETERS]
 *.NSVTY.CTRL_MODE := "client"
diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default
index 4d6c0a2..6f633d2 100644
--- a/pcu/PCU_Tests.default
+++ b/pcu/PCU_Tests.default
@@ -30,7 +30,6 @@
 };
 Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoPCU";
 PCUIF_Types.mp_pcuif_version := 10;
-StatsD_Checker.mp_enable_stats := true;
 
 [TESTPORT_PARAMETERS]
 *.PCU.socket_type := "SEQPACKET"

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e2049c109986906d3c985ca2282174b1abff581
Gerrit-Change-Number: 23113
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/292c1404/attachment.htm>


More information about the gerrit-log mailing list