This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23123 ) Change subject: kernel-test: add KERNEL_TEST_KVM env var ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh File jenkins-common.sh: https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@198 PS1, Line 198: if [ "$KERNEL_TEST_KVM" != 0 ]; then > iiuc you are doing string comparisong here, so better use "0"? or "z$KERNEL_TEST_KVM" != "z0" or wh […] Yes, '!=' is always doing string comparison (see 'man test'). "" is needed around variables $FOO, but not around strings without special characters (spaces, ...). z$FOO is only needed if using `set -u` (which I personally don't like so much, as it makes the code less readable with little to none practical benefit). So this comes down to personal preference... really, I think this line is pretty clear as it is. https://gerrit.osmocom.org/c/docker-playground/+/23123/1/jenkins-common.sh@221 PS1, Line 221: if [ "$KERNEL_TEST_KVM" != 0 ] && ! [ -e /dev/kvm ]; then > Why not simply mounting /dev/kvm automatically if it exists? let's not add more flags which are not […] This is useful to run the same code path locally, as it would run on jenkins. Even if KVM is available locally. Noted this in the commit message. https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh File ttcn3-ggsn-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/23123/1/ttcn3-ggsn-test/jenkins.sh@68 PS1, Line 68: sleep 5 > so it seems we finally need some sort of synchronization point? ;) Right, that would be more elegant. Added it again. I chose to grep the log file (like the smoke test), because there's no shared directory between docker and QEMU. > Please add a comment explaining why is this needed. The new function has a descriptive name, so there should be no need to describe it in jenkins.sh. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1f337af1e2de6db05b22636bc31a535404235559 Gerrit-Change-Number: 23123 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 26 Feb 2021 14:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210226/71dbb3d1/attachment.htm>