Change in docker-playground[master]: Remove test backward compatibility with older osmo-* versions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Feb 25 11:31:15 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/23053 )

Change subject: Remove test backward compatibility with older osmo-* versions
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1: -Code-Review
> > > 
> > > I started doing the change, but I realized I actually prefer getting them removed completely.
> > > 
> > > This allows quickly checking which tests have specific quirks for latest, and getting them removed when a new release is done, eg: grep -r \"latest\"
> > 
> > You can still check whether a specific test suite has backwards compatibility quirks, depending on what the conditional block contains. I see no problem with that, so I am not convinced. Why would people need to resurrect something from the history if we can just keep it?
> 
> You need to open each file to look at the contents of each if block then, or use a quite more advance grep command to check more stuff -> not handy.
> 
> Morevoer, following your same reasoning: Why should we keep something if we can resurrect it from history when needed? That's what version controls are for.

Missed this conversation. I agree with Pau, being able to grep for latest is useful, I suggest to remove it. If we want some kind of reference for this, we can put it in README.


-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/23053
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6f491b58d4576b22c8ff3ab56a7b9e17163a8739
Gerrit-Change-Number: 23053
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Feb 2021 11:31:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210225/4916e388/attachment.htm>


More information about the gerrit-log mailing list