Change in pysim[master]: serial: don't crash if the device does not exist

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Feb 22 18:38:28 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23029 )

Change subject: serial: don't crash if the device does not exist
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/23029/2/pySim/transport/serial.py 
File pySim/transport/serial.py:

https://gerrit.osmocom.org/c/pysim/+/23029/2/pySim/transport/serial.py@38 
PS2, Line 38: 		if (os.path.exists(device) == False):
Coding style:

  if not os.path.exists(device):
    ...


https://gerrit.osmocom.org/c/pysim/+/23029/2/pySim/transport/serial.py@39 
PS2, Line 39:  
Coding style: this space is not needed here.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23029
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7545c728b531e9a796eee8f80f0b08d4097f8399
Gerrit-Change-Number: 23029
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Feb 2021 18:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210222/964b9d9c/attachment.htm>


More information about the gerrit-log mailing list