Change in osmo-bts[master]: tests: Explicitly drop category from log

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Feb 20 17:12:52 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22983 )

Change subject: tests: Explicitly drop category from log
......................................................................

tests: Explicitly drop category from log

Let's disable category here since we don't care about its formatting here.

In any case, every test relying on logging output validation should
always explicitly state the config to avoid issues in the future if
default values change.

Change-Id: I8713f4e04e92b4d7e211c499fc6e78983edfb139
Related: OS#5034
---
M tests/power/bs_power_loop_test.c
M tests/power/ms_power_loop_test.c
M tests/tx_power/tx_power_test.c
3 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/tests/power/bs_power_loop_test.c b/tests/power/bs_power_loop_test.c
index 6f5f2bf..0c9bbbf 100644
--- a/tests/power/bs_power_loop_test.c
+++ b/tests/power/bs_power_loop_test.c
@@ -527,6 +527,8 @@
 	osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG;
 	log_set_print_filename(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 #define exec_test(test) \
 	exec_power_test(test, ARRAY_SIZE(test), #test)
diff --git a/tests/power/ms_power_loop_test.c b/tests/power/ms_power_loop_test.c
index c58812b..d7f4ea8 100644
--- a/tests/power/ms_power_loop_test.c
+++ b/tests/power/ms_power_loop_test.c
@@ -325,6 +325,8 @@
 	osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG;
 	log_set_print_filename(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 	test_power_loop();
 	test_pf_algo_ewma();
diff --git a/tests/tx_power/tx_power_test.c b/tests/tx_power/tx_power_test.c
index dbabc87..c3a8b4e 100644
--- a/tests/tx_power/tx_power_test.c
+++ b/tests/tx_power/tx_power_test.c
@@ -249,6 +249,8 @@
 	osmo_stderr_target->categories[DL1C].loglevel = LOGL_DEBUG;
 	log_set_print_filename(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 
 	bts = gsm_bts_alloc(tall_bts_ctx, 0);
 	if (!bts) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8713f4e04e92b4d7e211c499fc6e78983edfb139
Gerrit-Change-Number: 22983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210220/2fe37a6c/attachment.htm>


More information about the gerrit-log mailing list