Change in osmo-bsc[master]: Disallow changing the type of an existing BTS from the vty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Fri Feb 19 18:37:14 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22964 )

Change subject: Disallow changing the type of an existing BTS from the vty
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/22964/2/src/osmo-bsc/bts.c 
File src/osmo-bsc/bts.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22964/2/src/osmo-bsc/bts.c@495 
PS2, Line 495: 	if (bts->type && type != bts->type)
> since type is an enum, let's better compare agains the _UNKNOWN value, instead of checking non-zero.
Thanks. I think I've done what you mean :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22964
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0df97ef128a1bbd84c787654d1d842dce4dad819
Gerrit-Change-Number: 22964
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Feb 2021 18:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210219/9da13a87/attachment.htm>


More information about the gerrit-log mailing list