Change in osmo-bsc[master]: tests: Explicitly drop category from log

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Feb 19 12:41:44 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22981 )


Change subject: tests: Explicitly drop category from log
......................................................................

tests: Explicitly drop category from log

Let's disable category here since we don't care about its formatting here.

In any case, every test relying on logging output validation should
always explicitly state the config to avoid issues in the future if
default values change.

Change-Id: I4d48c0c0aa46065560a020369e3b0544385f173e
Related: OS#5034
---
M tests/acc/acc_test.c
M tests/subscr/bsc_subscr_test.c
2 files changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/22981/1

diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c
index 73757c7..759ff13 100644
--- a/tests/acc/acc_test.c
+++ b/tests/acc/acc_test.c
@@ -495,7 +495,8 @@
 	tall_bsc_ctx = talloc_named_const(NULL, 0, "gsm0408_test");
 	osmo_init_logging2(tall_bsc_ctx, &log_info);
 	log_set_log_level(osmo_stderr_target, LOGL_INFO);
-	log_set_print_category_hex(osmo_stderr_target, false);
+	log_set_print_category_hex(osmo_stderr_target, 0);
+	log_set_print_category(osmo_stderr_target, 0);
 	log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);
 	log_set_use_color(osmo_stderr_target, 0);
 	osmo_fsm_log_addr(false);
diff --git a/tests/subscr/bsc_subscr_test.c b/tests/subscr/bsc_subscr_test.c
index 619d5e6..77769a1 100644
--- a/tests/subscr/bsc_subscr_test.c
+++ b/tests/subscr/bsc_subscr_test.c
@@ -134,6 +134,7 @@
 	log_set_print_filename(osmo_stderr_target, 0);
 	log_set_print_timestamp(osmo_stderr_target, 0);
 	log_set_use_color(osmo_stderr_target, 0);
+	log_set_print_category_hex(osmo_stderr_target, 0);
 	log_set_print_category(osmo_stderr_target, 1);
 
 	bsc_subscribers = talloc_zero(ctx, struct llist_head);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4d48c0c0aa46065560a020369e3b0544385f173e
Gerrit-Change-Number: 22981
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210219/039c501a/attachment.htm>


More information about the gerrit-log mailing list