Change in osmo-pcu[master]: Use ALPHA value received in SI13 from PCUIF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Feb 18 18:40:32 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22801 )

Change subject: Use ALPHA value received in SI13 from PCUIF
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c 
File src/pcu_vty.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/22801/1/src/pcu_vty.c@746 
PS1, Line 746: 		the_pcu->vty.force_alpha = atoi(argv[0]);
> The problem is that these warnings are being printed in the beginning of the log without a prefix wi […]
I'm sorry but I disagree, I see no point in spending time in doing that. If you are a user see something is deprecated, and the message is already pointing you to use the new command, do so, instead of thinking how using the old deprecated command is going to affect the program. You should stop using it in first place.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22801
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I46f2a955b157a409055fca7fb917dc4f75482426
Gerrit-Change-Number: 22801
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Feb 2021 18:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210218/a45ed642/attachment.htm>


More information about the gerrit-log mailing list