Change in osmo-bsc[master]: Set FSM pointer to NULL when changing BTS Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Feb 18 07:38:46 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22954 )

Change subject: Set FSM pointer to NULL when changing BTS Type
......................................................................


Patch Set 3:

> I get that one shouldn't be changing BTS type at runtime, but we really don't want a running osmo-bsc to CRASH because the operator typed something in the vty, right? 

of course.

> One might actually bring it up with a blank or default config and then try to configure via the vty.

yes. Probably come up either with a new "undefined" type, have that set at start-up and then only allow undefined -> specific changes via VTY and prevent all further chnages sounds good.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I634fe52d598253454a50cb782d93ada83e6d88d1
Gerrit-Change-Number: 22954
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 18 Feb 2021 07:38:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210218/c51f5cb9/attachment.htm>


More information about the gerrit-log mailing list