Change in osmo-bsc[master]: stats: add SIGN/SPEECH assignment subcategories

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

iedemam gerrit-no-reply at lists.osmocom.org
Wed Feb 17 15:18:53 UTC 2021


iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 )

Change subject: stats: add SIGN/SPEECH assignment subcategories
......................................................................


Patch Set 3:

(1 comment)

Hi,

Much cleaner now I think. All switch()ing is now done within assignment_count().

There is, however, a special case for BTS_CTR_ASSIGNMENT_NO_CHANNEL as chan_mode is not available in lchan but only in the unfulfilled request.

-Michael

https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c 
File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c@102 
PS2, Line 102: #define assignment_count_result(counter) do { \
> I would at least give it a try if you don't mind, I fear otherwise we are filling lots of code with  […]
Pushed in patchset 3.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I73f4dab6edb0951180f2bbcfc352ff34de647679
Gerrit-Change-Number: 22947
Gerrit-PatchSet: 3
Gerrit-Owner: iedemam <michael at kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Feb 2021 15:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael at kapsulate.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210217/7a5fdc86/attachment.htm>


More information about the gerrit-log mailing list