This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22947 ) Change subject: stats: add SIGN/SPEECH assignment subcategories ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c@102 PS2, Line 102: #define assignment_count_result(counter) do { \ did you think about extending this one with a "chan_mode" param and do the rate_ctr_inc only once here? as in ##counter_SIGN and ##counter_SPEECH or alike. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73f4dab6edb0951180f2bbcfc352ff34de647679 Gerrit-Change-Number: 22947 Gerrit-PatchSet: 2 Gerrit-Owner: iedemam <michael at kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 17 Feb 2021 12:17:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210217/e269ea1d/attachment.htm>