Change in libosmocore[master]: gprs_ns2: rework IP-SNS binds

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Tue Feb 16 16:27:49 UTC 2021


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22872 )

Change subject: gprs_ns2: rework IP-SNS binds
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@100 
PS8, Line 100: 	{ GPRS_SNS_EV_REQ_ADD_BIND,		"ADD_BIND"},
> wrong indentation?
Done


https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@125 
PS8, Line 125: 	struct ns2_sns_bind *current_bind;
> I wonder, if there's only 1 current bind, why do we need a list entry and not simply a pointer to th […]
it's similiar to the *initial, but it's a bind instead of an endpoint. i'll renmae initial_bind



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9ab8092bf286e7d90e92f5702a5404425e959c84
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Feb 2021 16:27:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/bada4b39/attachment.htm>


More information about the gerrit-log mailing list