Change in libosmocore[master]: gprs_ns2: rework IP-SNS binds

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22872 )

Change subject: gprs_ns2: rework IP-SNS binds
......................................................................


Patch Set 9:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c 
File src/gb/gprs_ns2_sns.c:

https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@100 
PS8, Line 100: 	{ GPRS_SNS_EV_REQ_ADD_BIND,		"ADD_BIND"},
wrong indentation?


https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@125 
PS8, Line 125: 	struct ns2_sns_bind *current_bind;
I wonder, if there's only 1 current bind, why do we need a list entry and not simply a pointer to the object? Or can there be several "current" ones? The naming is then a bit confusing Should it then be called "current_binds" then.


https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@790 
PS8, Line 790: 			bind = sbind->bind;
bind bind bind



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22872
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9ab8092bf286e7d90e92f5702a5404425e959c84
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Feb 2021 15:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210216/51f22d9f/attachment.htm>